fix(cdk/testing): Skip task tracking if zone patches aren't present #32544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit omits the initialization of the `taskState` when the constructor executes outside the proxy zone. This would generally indicate that either `zone.js/dist/zone-testing.js` was not included _or_ it does not include patches for the test framework being used (e.g. Vitest). In this case, we should simply omit the initialization of task state tracking, meaning that `waitForTasksOutsideAngular` will "not work" and simply be a `Promise.resolve`. fixes angular#32542
tjshiu
approved these changes
Dec 15, 2025
andrewseguin
approved these changes
Dec 16, 2025
andrewseguin
added
action: merge
Contributor
andrewseguin
pushed a commit
that referenced
this pull request
Dec 17, 2025
…32544) This commit omits the initialization of the `taskState` when the constructor executes outside the proxy zone. This would generally indicate that either `zone.js/dist/zone-testing.js` was not included _or_ it does not include patches for the test framework being used (e.g. Vitest). In this case, we should simply omit the initialization of task state tracking, meaning that `waitForTasksOutsideAngular` will "not work" and simply be a `Promise.resolve`. fixes #32542 (cherry picked from commit dd40f25)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit omits the initialization of the
taskStatewhen the constructor executes outside the proxy zone. This would generally indicate that eitherzone.js/dist/zone-testing.jswas not included or it does not include patches for the test framework being used (e.g. Vitest). In this case, we should simply omit the initialization of task state tracking, meaning thatwaitForTasksOutsideAngularwill "not work" and simply be aPromise.resolve.fixes #32542